refactor!: Base combo box styles #8932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Apr 15, 2025
web-padawan
reviewed
Apr 15, 2025
web-padawan
force-pushed
the
base-styles
branch
from
e01831c to
d63d974
Compare
web-padawan
force-pushed
the
base-combo-box
branch
from
3928b71 to
5195b5d
Compare
web-padawan
reviewed
Apr 22, 2025
web-padawan
force-pushed
the
base-styles
branch
from
ee5b8fe to
ce4b0e6
Compare
web-padawan
force-pushed
the
base-combo-box
branch
from
5195b5d to
94d978b
Compare
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan
force-pushed
the
base-combo-box
branch
from
d599582 to
0d9c9b4
Compare
web-padawan
requested changes
Apr 23, 2025
There was a problem hiding this comment.
Rebased again. Some tests are failing, please do not merge until I fix those:
packages/combo-box/test/keyboard-lit.generated.test.js:
❌ keyboard > scrolling items > should scroll up after reaching the first visible item
AssertionError: expected 1 to deeply equal 2
+ expected - actual
-1
+2
at n.<anonymous> (packages/combo-box/test/keyboard-lit.generated.test.js:484:54)
❌ keyboard > scrolling items > should scroll to first visible when navigating down above viewport
AssertionError: expected 5 to deeply equal 6
+ expected - actual
-5
+6
at n.<anonymous> (packages/combo-box/test/keyboard-lit.generated.test.js:497:54)
❌ keyboard > scrolling items > should scroll to first visible when navigating up above viewport
AssertionError: expected 3 to deeply equal 4
+ expected - actual
-3
+4
at n.<anonymous> (packages/combo-box/test/keyboard-lit.generated.test.js:506:54)
web-padawan
approved these changes
Apr 23, 2025
move declaration higher in the DOM hierarchy
|
|
I fixed the CSS lint errors directly in the |
|
@web-padawan, I’m not sure about the other test failures, if those are the ones you deemed unrelated to this PR. |
jouni
approved these changes
Apr 23, 2025
|
There are some multi-select-combo-box chip tests failing, I'll look into fixing those separately. Let's merge this PR. |
web-padawan
pushed a commit
that referenced
this pull request
Apr 23, 2025
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
web-padawan
pushed a commit
that referenced
this pull request
Apr 24, 2025
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New and changed base style properties
--_vaadin-icon-checkmark--_vaadin-icon-chevron-downNew Combo Box base style
Supported custom properties
--vaadin-combo-box-spinner-color--vaadin-combo-box-overlay-width--vaadin-item-border-radius--vaadin-item-checkmark-color--vaadin-item-gap--vaadin-item-height--vaadin-item-overlay-padding--vaadin-item-padding